Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-installed version of commit lint in ockam-builder docker image #4522

Closed
metaclips opened this issue Mar 23, 2023 · 10 comments · Fixed by #6797
Closed

Use pre-installed version of commit lint in ockam-builder docker image #4522

metaclips opened this issue Mar 23, 2023 · 10 comments · Fixed by #6797
Labels
Component: CI/CD good first issue hacktoberfest Apply to issues you want contributors to help with help wanted

Comments

@metaclips
Copy link
Member

metaclips commented Mar 23, 2023

Current behavior

To lint commit, we currently install commit-lint for every lint_commit job run which increases time for CI test to complete

- name: Install Commitlint
run: npm install --location=global @commitlint/[email protected] # TODO: move to ockam-builder docker image.

Desired behavior

We now have commit-lint pre-installed into our builder image

npm --global config set user root && \
npm install --global @commitlint/cli@${COMMITLINT_VERSION}; \

we should use our builder image as our default image in the lint_commits job.


We love helping new contributors! ❤️
If you have questions or need help as you explore, please join us on Discord. If you're looking for other issues to contribute to, please checkout our good first issues.

@chanman3388
Copy link
Contributor

May I take this?

@etorreborre
Copy link
Member

@chanman3388 absolutely, you're welcome!

@chanman3388
Copy link
Contributor

chanman3388 commented Mar 30, 2023

Something I needed to ask, are you expecting the docker image for ockam-builder to be built during the workflow? Or do you have a registry that you want the image pulled from?

Or does a job need to be created to build the builder image a bit like this workflow? https://github.com/build-trust/ockam/actions/runs/854017429/jobs/836428411

@metaclips
Copy link
Member Author

Something I needed to ask, are you expecting the docker image for ockam-builder to be built during the workflow? Or do you have a registry that you want the image pulled from?

Or does a job need to be created to build the builder image a bit like this workflow? https://github.com/build-trust/ockam/actions/runs/854017429/jobs/836428411

We don't need to build the image as that has already been done, the recent ockam-builder image

image: ghcr.io/build-trust/ockam-builder@sha256:0a4c3640f78650e35207a047891e55863d8648a9333ea0bcfe03f09e2d57480c
already has support for commitlint.

@itsajay1029
Copy link
Contributor

Can I work on this @etorreborre @metaclips ?

@metaclips
Copy link
Member Author

Can I work on this @etorreborre @metaclips ?

@chanman3388 are you still taking this up?

@chanman3388
Copy link
Contributor

Can I work on this @etorreborre @metaclips ?

@chanman3388 are you still taking this up?

No I'm not, you're welcome to it!

@metaclips
Copy link
Member Author

@itsajay1029 assigned to you, do ask if you need more clarification

@nazmulidris
Copy link
Contributor

@itsajay1029 Thank you for taking the time to look at this issue. Since you’ve not had a chance we’re opening the issue up for other contributors.

@nazmulidris nazmulidris added the hacktoberfest Apply to issues you want contributors to help with label Sep 25, 2023
@Salonikansal2
Copy link
Contributor

I have submitted by pr for this issue .please check @metaclips

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CI/CD good first issue hacktoberfest Apply to issues you want contributors to help with help wanted
Projects
None yet
6 participants