-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pre-installed version of commit lint in ockam-builder
docker image
#4522
Comments
May I take this? |
@chanman3388 absolutely, you're welcome! |
Something I needed to ask, are you expecting the docker image for ockam-builder to be built during the workflow? Or do you have a registry that you want the image pulled from? Or does a job need to be created to build the builder image a bit like this workflow? https://github.com/build-trust/ockam/actions/runs/854017429/jobs/836428411 |
We don't need to build the image as that has already been done, the recent ockam/.github/workflows/rust.yml Line 55 in a111ea9
|
Can I work on this @etorreborre @metaclips ? |
@chanman3388 are you still taking this up? |
No I'm not, you're welcome to it! |
@itsajay1029 assigned to you, do ask if you need more clarification |
@itsajay1029 Thank you for taking the time to look at this issue. Since you’ve not had a chance we’re opening the issue up for other contributors. |
I have submitted by pr for this issue .please check @metaclips |
Current behavior
To lint commit, we currently install commit-lint for every lint_commit job run which increases time for CI test to complete
ockam/.github/workflows/all.yml
Lines 90 to 91 in 1b7d42a
Desired behavior
We now have commit-lint pre-installed into our builder image
ockam/tools/docker/builder/Dockerfile
Lines 80 to 81 in 1b7d42a
we should use our builder image as our default image in the
lint_commits job
.We love helping new contributors! ❤️
If you have questions or need help as you explore, please join us on Discord. If you're looking for other issues to contribute to, please checkout our good first issues.
The text was updated successfully, but these errors were encountered: