Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes#4522 Added pre-installed version of commit lint in ockam-builder docker image #6797

Merged
merged 1 commit into from
Oct 29, 2023
Merged

fixes#4522 Added pre-installed version of commit lint in ockam-builder docker image #6797

merged 1 commit into from
Oct 29, 2023

Conversation

Salonikansal2
Copy link
Contributor

@Salonikansal2 Salonikansal2 commented Oct 28, 2023 •
edited
Loading

added pre-installed version of commit lint in ockam-builder docker image #452
@nazmulidris
@metaclips

@Salonikansal2 Salonikansal2 requested a review from a team as a code owner October 28, 2023 11:47
@Salonikansal2 Salonikansal2 changed the title fixes#452 Added pre-installed version of commit lint in ockam-builder docker image fixes#4522 Added pre-installed version of commit lint in ockam-builder docker image Oct 28, 2023
@mrinalwadhwa mrinalwadhwa added hacktoberfest Apply to issues you want contributors to help with HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged labels Oct 28, 2023
@mrinalwadhwa
Copy link
Member

@Salonikansal2 while we still have to review this change. I'm adding the HACKTOBERFEST-ACCEPTED label so the contribution is counted by hacktoberfest bots before the end of October. Thank you for taking time to contribute 🎉

@Salonikansal2
Copy link
Contributor Author

Thanks for your efforts @mrinalwadhwa

@Salonikansal2
Copy link
Contributor Author

gentle reminder to review changes
@metaclips
@adrianbenavides

metaclips
metaclips approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@metaclips metaclips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Salonikansal2 for working on this issue and apologies for the late reply. I amended the Dockerfile to indicate to where commitlint was installed

@metaclips metaclips enabled auto-merge October 29, 2023 16:48
@metaclips metaclips self-requested a review October 29, 2023 16:56
@metaclips metaclips linked an issue Oct 29, 2023 that may be closed by this pull request
Use pre-installed version of commit lint in ockam-builder docker image #4522
Closed
@mrinalwadhwa mrinalwadhwa self-requested a review October 29, 2023 17:04
@metaclips metaclips added this pull request to the merge queue Oct 29, 2023
Merged via the queue into build-trust:develop with commit b872a7b Oct 29, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrinalwadhwa mrinalwadhwa mrinalwadhwa approved these changes

@metaclips metaclips Awaiting requested review from metaclips

Assignees
No one assigned
Labels
hacktoberfest Apply to issues you want contributors to help with HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use pre-installed version of commit lint in ockam-builder docker image
3 participants
@Salonikansal2 @mrinalwadhwa @metaclips