feat(rust): Add JSON output support for vault list and vault show
#6184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solidiquis
commented
Sep 29, 2023
|
Will address failing tests/lints shortly :) edit: Resolved |
solidiquis
force-pushed
the
solidiquis/json-support-vault-list
branch
3 times, most recently
from
ae74de8 to
0d676c0
Compare
There was a problem hiding this comment.
Looks great, thanks @solidiquis for fixing these issues! I've added a couple of comments to keep the tests' checks as they were before.
solidiquis
force-pushed
the
solidiquis/json-support-vault-list
branch
from
0d676c0 to
7c42d2f
Compare
|
Thanks again @adrianbenavides for the assist! Just updated the test. Will be more diligent with that next time around. |
solidiquis
force-pushed
the
solidiquis/json-support-vault-list
branch
from
7c42d2f to
cc039ec
Compare
mrinalwadhwa
added
the
hacktoberfest
solidiquis
force-pushed
the
solidiquis/json-support-vault-list
branch
2 times, most recently
from
813aabe to
c1f3b8e
Compare
adrianbenavides
force-pushed
the
solidiquis/json-support-vault-list
branch
from
c1f3b8e to
9d347c8
Compare
adrianbenavides
added
the
HACKTOBERFEST-ACCEPTED
adrianbenavides
force-pushed
the
solidiquis/json-support-vault-list
branch
from
9d347c8 to
4a48c6b
Compare
adrianbenavides
force-pushed
the
solidiquis/json-support-vault-list
branch
from
4a48c6b to
7962d61
Compare
adrianbenavides
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Thanks @solidiquis for your contribution 🙏
It will get merged ASAP 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior
--output jsonis currently unsupported forvault listandvault showProposed changes
This PR adds support for
--output jsonforvault listandvault showby derivingSerializeforVaultStateto produce and write JSON strings in relevant areas.Updated
implementations/rust/ockam/ockam_command/tests/bats/vault.batsas well to test for partial equivalence with JSON output since the JSON output takes precedence over the plain variant whenstdoutisn't a tty.ockam vault listby implementing--output json#6139ockam vault showby adding support for--output json#6135ockam vault listby adding--output json#6136 (redundant with issue 6135)Screenshots:
Checks