Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed status error messages #6196

Merged

Conversation

rjtch
Copy link
Contributor

@rjtch rjtch commented Sep 30, 2023

Current behavior

Proposed changes

Fixes #6064

Checks

  • All commits in this Pull Request are signed and Verified by Github.
  • All commits in this Pull Request follow the Ockam commit message convention.
  • There are no Merge commits in this Pull Request. The Ockam repo maintains a linear commit history so we merge PRs by rebasing them to the develop branch. Rebasing to the latest develop branch and force pushing to your PR branch is okay.
  • I accept the Ockam Community Code of Conduct.
  • I have accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a PR, this will mark the commit as verified.

@rjtch rjtch requested a review from a team as a code owner September 30, 2023 12:57
@mrinalwadhwa mrinalwadhwa added the hacktoberfest Apply to issues you want contributors to help with label Oct 2, 2023
@adrianbenavides adrianbenavides force-pushed the feat/changed-status-message branch from 4694888 to b9d7ded Compare October 3, 2023 09:48
@adrianbenavides adrianbenavides force-pushed the feat/changed-status-message branch from b9d7ded to ef77b08 Compare October 3, 2023 09:52
@adrianbenavides adrianbenavides added the HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged label Oct 3, 2023
Copy link
Member

@adrianbenavides adrianbenavides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rjtch for your contribution 🚀 LTGM!

@adrianbenavides adrianbenavides added this pull request to the merge queue Oct 3, 2023
Merged via the queue into build-trust:develop with commit 5019283 Oct 3, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Apply to issues you want contributors to help with HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ockam status should provide more user friendly information when a user is *not* enrolled
4 participants