Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve enroll help message #6197

Merged
merged 1 commit into from
Oct 3, 2023
Merged

improve enroll help message #6197

merged 1 commit into from
Oct 3, 2023

Conversation

rjtch
Copy link
Contributor

@rjtch rjtch commented Sep 30, 2023 •
edited by adrianbenavides
Loading

Current behavior

Proposed changes

Fixes #6055

Checks

  • All commits in this Pull Request are signed and Verified by Github.
  • All commits in this Pull Request follow the Ockam commit message convention.
  • There are no Merge commits in this Pull Request. The Ockam repo maintains a linear commit history so we merge PRs by rebasing them to the develop branch. Rebasing to the latest develop branch and force pushing to your PR branch is okay.
  • I accept the Ockam Community Code of Conduct.
  • I have accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a PR, this will mark the commit as verified.

@rjtch rjtch requested a review from a team as a code owner September 30, 2023 13:20
@mrinalwadhwa
Copy link
Member

To address the failing lint, could you amend the commit message to our format, something like:

docs(rust): improve help of global verbose flag in ockam command

@mrinalwadhwa mrinalwadhwa added the hacktoberfest Apply to issues you want contributors to help with label Oct 2, 2023
@adrianbenavides adrianbenavides force-pushed the feat/change-enroll-verbose-message-to-help branch 2 times, most recently from 87a5566 to b685f08 Compare October 3, 2023 09:57
@adrianbenavides adrianbenavides force-pushed the feat/change-enroll-verbose-message-to-help branch from b685f08 to 1cafccf Compare October 3, 2023 09:58
@etorreborre etorreborre changed the title imporve enroll help message improve enroll help message Oct 3, 2023
@adrianbenavides adrianbenavides force-pushed the feat/change-enroll-verbose-message-to-help branch 3 times, most recently from f4dd75f to af1daff Compare October 3, 2023 10:06
@adrianbenavides adrianbenavides added the HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged label Oct 3, 2023
@adrianbenavides adrianbenavides force-pushed the feat/change-enroll-verbose-message-to-help branch from af1daff to 71ed53e Compare October 3, 2023 11:44
@adrianbenavides adrianbenavides force-pushed the feat/change-enroll-verbose-message-to-help branch from 71ed53e to 964a5c7 Compare October 3, 2023 11:48
adrianbenavides
adrianbenavides approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@adrianbenavides adrianbenavides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rjtch for your contribution 🙏
It will get merged ASAP 🚀

@adrianbenavides adrianbenavides added this pull request to the merge queue Oct 3, 2023
Merged via the queue into build-trust:develop with commit eae2711 Oct 3, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrinalwadhwa mrinalwadhwa mrinalwadhwa left review comments

@adrianbenavides adrianbenavides adrianbenavides approved these changes

@SanjoDeundiak SanjoDeundiak SanjoDeundiak approved these changes

Assignees
No one assigned
Labels
hacktoberfest Apply to issues you want contributors to help with HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve ockam enroll —-help text by adding doc comment for verbose flag
4 participants
@rjtch @mrinalwadhwa @SanjoDeundiak @adrianbenavides