Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move packages:write in the ockam-healthcheck workflow #6203

Merged
merged 1 commit into from
Sep 30, 2023
Merged

ci: move packages:write in the ockam-healthcheck workflow #6203

merged 1 commit into from
Sep 30, 2023

Conversation

tharun634
Copy link
Contributor

@tharun634 tharun634 commented Sep 30, 2023

Current behavior

In ockam-healthcheck workflow, we have set packages: write permission in the workflow-scope, which can be controlled further by moving the permission to build_ockam_healthcheck job-scope

Proposed changes

Checks

  • All commits in this Pull Request are signed and Verified by Github.
  • All commits in this Pull Request follow the Ockam commit message convention.
  • There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
  • I have read and accept the Ockam Community Code of Conduct.
  • I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@metaclips metaclips added this pull request to the merge queue Sep 30, 2023
Merged via the queue into build-trust:develop with commit a3d60c5 Sep 30, 2023
@mrinalwadhwa mrinalwadhwa added HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged hacktoberfest Apply to issues you want contributors to help with labels Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Apply to issues you want contributors to help with HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the packages:write permission in the ockam-healthcheck workflow
3 participants