Remove the skip_defaults flag
#6214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianbenavides
previously approved these changes
Oct 2, 2023
|
@etorreborre looks like the authority node initialization is not being done properly (two bats tests failing), but I can't seem to see what's wrong. |
etorreborre
force-pushed
the
etorreborre/refactor/skip-defaults-flag
branch
from
a9afa5d to
b32cefe
Compare
|
@adrianbenavides I fixed the issue, the authority tests are passing now. |
adrianbenavides
previously approved these changes
Oct 2, 2023
the only case where it is needed is when starting a new node and this can be determined by the presence / absence of a launch config file
etorreborre
force-pushed
the
etorreborre/refactor/skip-defaults-flag
branch
from
b32cefe to
16907a0
Compare
adrianbenavides
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
skip_defaultsflag used when creating aNodeManagerdoes not need to be kept on the struct for its whole lifetime.That flag is set to
truewhen a launch config has been passed on the command line and is otherwise set tofalse.