Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doriancodes/add docs to full flag #6239

Conversation

doriancodes
Copy link
Contributor

Current behavior

Currently when you run ockam identity show you can pass a flag --full. This flag is currently does not have any help

Proposed changes

Now when you run ockam identity show you can you can see the documentation for the flag --full.

Checks

  • [x ] All commits in this Pull Request are signed and Verified by Github.
  • [ x] All commits in this Pull Request follow the Ockam commit message convention.
  • [ x] There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
  • [x ] I have read and accept the Ockam Community Code of Conduct.
  • I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@doriancodes doriancodes requested a review from a team as a code owner October 3, 2023 11:42
@adrianbenavides
Copy link
Member

Hi @doriancodes, I'm sorry but someone else fixed this issue at #6213. We try to avoid collisions but it's really hard with so many people creating PR's!

Good news are that we have plenty of issues to choose from. I'd recommend you the following issues, which are very similar to this one:

Thanks for spending your time on this PR and sorry again 🙏

@mrinalwadhwa
Copy link
Member

@doriancodes Thank you got spending time on this. In case you're participating in Hacktoberfest ... Even though we decided not to land this change because of the overlap, I've added the HACKTOBERFEST-ACCEPTED label so it gets counted toward that. Thank you!

@mrinalwadhwa mrinalwadhwa added the HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged label Oct 3, 2023
@mrinalwadhwa
Copy link
Member

When you get a chance please add yourself to the Ockam Contributors list by accepting our Contributor License Agreement

The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a PR, this will mark the commit as verified.

@doriancodes
Copy link
Contributor Author

@mrinalwadhwa thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants