Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): fix help messages of some CLI commands #6304

Conversation

janithjeewantha
Copy link
Contributor

I noticed that the help messages of "ockam tcp-outlet" and "ockam tcp-inlet" display a wrong message for the "show" commands.

image

Those were corrected by updating the comments used by Clap.

image

Checks

  • All commits in this Pull Request are signed and Verified by Github.
  • All commits in this Pull Request follow the Ockam commit message convention.
  • There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
  • I have read and accept the Ockam Community Code of Conduct.
  • I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@janithjeewantha janithjeewantha requested a review from a team as a code owner October 4, 2023 18:54
@mrinalwadhwa mrinalwadhwa added the hacktoberfest Apply to issues you want contributors to help with label Oct 5, 2023
@mrinalwadhwa mrinalwadhwa mentioned this pull request Oct 5, 2023
5 tasks
@adrianbenavides
Copy link
Member

Hey @janithjeewantha, was this PR closed accidentally?

@janithjeewantha
Copy link
Contributor Author

janithjeewantha commented Oct 5, 2023

Hey @janithjeewantha, was this PR closed accidentally?

Hi @adrianbenavides ,
I think @mrinalwadhwa closed it because I had not accepted the CLA then.
I had to close the CLA PR because I had some troubles and had to delete my fork. So the PR for the CLA acceptance #6290 and another just like this one #6296 had become invalid so I closed them.
Sorry about the mess.

I submitted a new PR shortly for CLA #6307 and @mrinalwadhwa had merged it. So I believe this one can be merged now if possible.

@adrianbenavides
Copy link
Member

@janithjeewantha I just confirmed with @mrinalwadhwa that it was accidentally closed. Sometimes GitHub does weird stuff when you link issues and PR's between each other. I'll review it ASAP!

@janithjeewantha janithjeewantha force-pushed the janithjeewantha/fix-help-messages-of-tcp-inlet-outlet-show-commands branch 3 times, most recently from 88f2731 to fa7d8dd Compare October 5, 2023 13:57
@adrianbenavides adrianbenavides force-pushed the janithjeewantha/fix-help-messages-of-tcp-inlet-outlet-show-commands branch from b29d327 to 2b80eee Compare October 6, 2023 07:39
Copy link
Member

@adrianbenavides adrianbenavides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge, thanks @janithjeewantha for this contribution!! 🚀

@adrianbenavides adrianbenavides added this pull request to the merge queue Oct 6, 2023
@adrianbenavides adrianbenavides added the HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged label Oct 6, 2023
Merged via the queue into build-trust:develop with commit f9d7225 Oct 6, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Apply to issues you want contributors to help with HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants