Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ockam relay list --help documentation #6356

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Improve ockam relay list --help documentation #6356

merged 1 commit into from
Oct 10, 2023

Conversation

0scvr
Copy link
Contributor

@0scvr 0scvr commented Oct 7, 2023 •
edited
Loading

Current behavior

See #6297

Proposed changes

Updated ockam relay list's long about description, example and --to argument description.

Checks

  • All commits in this Pull Request are signed and Verified by Github.
  • All commits in this Pull Request follow the Ockam commit message convention.
  • There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
  • I have read and accept the Ockam Community Code of Conduct.
  • I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

Answers #6297.

@0scvr 0scvr requested a review from a team as a code owner October 7, 2023 13:41
@mrinalwadhwa mrinalwadhwa added the hacktoberfest Apply to issues you want contributors to help with label Oct 7, 2023
@mrinalwadhwa mrinalwadhwa linked an issue Oct 7, 2023 that may be closed by this pull request
Improve ockam relay list --help by mentioning it works w/ Orchestrator enrollment by default #6297
Closed
@adrianbenavides adrianbenavides added the HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged label Oct 10, 2023
@adrianbenavides adrianbenavides self-requested a review October 10, 2023 07:47
adrianbenavides
adrianbenavides previously approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@adrianbenavides adrianbenavides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM! 🚀

Thank you @0scvr 🙏

@etorreborre etorreborre self-requested a review October 10, 2023 09:21
@adrianbenavides adrianbenavides added this pull request to the merge queue Oct 10, 2023
Merged via the queue into build-trust:develop with commit 05cea02 Oct 10, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etorreborre etorreborre etorreborre approved these changes

@adrianbenavides adrianbenavides adrianbenavides left review comments

Assignees
No one assigned
Labels
hacktoberfest Apply to issues you want contributors to help with HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve ockam relay list --help by mentioning it works w/ Orchestrator enrollment by default
4 participants
@0scvr @etorreborre @adrianbenavides @mrinalwadhwa