Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ockam/credential): set the vault argument value name on ockam credential issue #6418

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

AshwinKul28
Copy link
Contributor

@AshwinKul28 AshwinKul28 commented Oct 9, 2023

Set the VAULT_NAME argument in the Ockam credential issue module and added a doc string describing the name of the Vault to be used for issuing credentials.

This change improves code readability and documentation for Vault usage.

Fixes #6386

Current behavior

The vault argument value name on ockam credential issue is not set.

Proposed changes

The vault argument value name on ockam credential issue changed to VAULT_NAME and a doc string changed with Name of the Vault that will be used to issue the credential.

Checks

  • All commits in this Pull Request are signed and Verified by Github.
  • All commits in this Pull Request follow the Ockam commit message convention.
  • There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
  • I have read and accept the Ockam Community Code of Conduct.
  • I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@AshwinKul28 AshwinKul28 requested a review from a team as a code owner October 9, 2023 17:17
@AshwinKul28
Copy link
Contributor Author

Created this PR - #6419 to get added to the contributors' list. Once added, I can check the last option in the above comment.

@AshwinKul28 AshwinKul28 changed the title feat(ockam/credential): set the vault argument value name on ockam credential issue fix(ockam/credential): set the vault argument value name on ockam credential issue Oct 9, 2023
@mrinalwadhwa mrinalwadhwa added the hacktoberfest Apply to issues you want contributors to help with label Oct 9, 2023
Copy link
Member

@adrianbenavides adrianbenavides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @AshwinKul28 , will get merged soon! 🚀

Thank you for your contribution 🙏

@adrianbenavides adrianbenavides added the HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged label Oct 10, 2023
@etorreborre etorreborre self-requested a review October 10, 2023 09:22
@adrianbenavides adrianbenavides added this pull request to the merge queue Oct 10, 2023
Merged via the queue into build-trust:develop with commit 4a99685 Oct 10, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Apply to issues you want contributors to help with HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged
Projects
None yet
4 participants