-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): delete relays interactive #6735
Conversation
@PanGan21 Thank you for spending time on this, before we can merge please
The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a PR, this will mark the commit as verified. |
Hi @mrinalwadhwa ! Thanks for the reminder. Is it required to be done in a separate pr or I can just push the new |
@PanGan21 in a separate PR please |
9a1c2eb
to
3197cc1
Compare
Hi @mrinalwadhwa would it be possible to review this pr in October? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @PanGan21 thanks for the PR! We are refactoring several commands to add the tui
experience. You should use the node delete
logic as a reference and keep the code as similar to that as possible.
Here is the code:
fn run_impl(opts: CommandGlobalOpts, cmd: DeleteCommand) -> miette::Result<()> { |
@PanGan21 while we still have to review this change. I'm adding the Please not @adrianbenavides's comment above. |
8a3ef2c
to
f386b51
Compare
a3d92db
to
0edea44
Compare
Hi! I did some refactoring, let me know what you think |
Current behavior
Errors out when the user doesn't specify a relay name.
Proposed changes
Closes #6464
relay_name
argument becomes optionalrelay_name
then uses the providedrelay_name
relay_name
and the terminal is interactive, and the user didn't pass any of --no-output or --quiet flags then the terminal shows all available relays and allows the user select one or more from a listChecks