Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes#6143 changed the error message #6796

Closed
wants to merge 4 commits into from

Conversation

Salonikansal2
Copy link
Contributor

@Salonikansal2 Salonikansal2 commented Oct 28, 2023

Fixes #6143
changed the error message displayed when local state is empty
@nazmulidris

@Salonikansal2 Salonikansal2 requested a review from a team as a code owner October 28, 2023 11:17
@mrinalwadhwa mrinalwadhwa added hacktoberfest Apply to issues you want contributors to help with HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged labels Oct 28, 2023
@mrinalwadhwa
Copy link
Member

@Salonikansal2 while we still have to review this change. I'm adding the HACKTOBERFEST-ACCEPTED label so the contribution is counted by hacktoberfest bots before the end of October. Thank you for taking time to contribute 🎉

@Salonikansal2
Copy link
Contributor Author

Thanks for your efforts @mrinalwadhwa

@Salonikansal2
Copy link
Contributor Author

gentle reminder to review changes
@adrianbenavides
@nazmulidris

@Salonikansal2
Copy link
Contributor Author

Salonikansal2 commented Oct 30, 2023

Gentle reminder , @nazmulidris , @adrianbenavides . Sorry for such hurry in behavior but actually I participated in hacksquad competition due to which I need them merged as soon as possible

@Salonikansal2
Copy link
Contributor Author

@metaclips

Copy link
Member

@adrianbenavides adrianbenavides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change should be done at the project list level, in this function.

You can use something like:

if !opts.state.is_enrolled()? {
    return Err(miette!("You must enroll before you can list your projects"));
}

@Salonikansal2
Copy link
Contributor Author

Sorry , for the late reply ,was busy in college.
Just summited my new pr #6808 by making the changes you suggested
@adrianbenavides
Thanks for your time

@adrianbenavides
Copy link
Member

Closed in favor of: #6808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Apply to issues you want contributors to help with HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve ockam project list when there are no projects
3 participants