Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust): fixed enrollment when not successfully completed on first try #6910

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix(rust): fixed enrollment when not successfully completed on first try #6910

merged 1 commit into from
Nov 17, 2023

Conversation

davide-baldo
Copy link
Member

This PR fixes two cases:

  1. When email is not verified, the enrollment would show up a notification but would continue, failing
  2. When en enrollment is interrupted and another one is performed with a different account, it would fail because the new user_info wouldn't be the default

@davide-baldo davide-baldo requested a review from a team as a code owner November 16, 2023 15:49
@davide-baldo davide-baldo added this pull request to the merge queue Nov 17, 2023
@davide-baldo davide-baldo force-pushed the davide-baldo/fix-partial-enrollment branch from 84d54cf to 723a22a Compare November 17, 2023 13:10
@davide-baldo davide-baldo removed this pull request from the merge queue due to a manual request Nov 17, 2023
@etorreborre etorreborre self-requested a review November 17, 2023 17:04
@davide-baldo davide-baldo added this pull request to the merge queue Nov 17, 2023
Merged via the queue into develop with commit baa85e4 Nov 17, 2023
26 checks passed
@davide-baldo davide-baldo deleted the davide-baldo/fix-partial-enrollment branch November 17, 2023 17:18
@davide-baldo davide-baldo mentioned this pull request Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etorreborre etorreborre etorreborre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davide-baldo @etorreborre