Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix persistence issues #6991

Merged
merged 9 commits into from
Nov 29, 2023
Merged

Fix persistence issues #6991

merged 9 commits into from
Nov 29, 2023

Conversation

etorreborre
Copy link
Member

This PR fixes a number of regressions after the merge of the database persistence PR:

  • incorrect use of the space id instead of the space name in a command
  • create the authority identity for the identity node if it doesn't exist
  • correctly stop nodes in the bats test suite when running concurrently
  • create a default identity only once when using the function accepting optional values

@etorreborre etorreborre self-assigned this Nov 29, 2023
@etorreborre etorreborre force-pushed the etorreborre/fix/persistence-issues branch from 41e4867 to e6a9ebf Compare November 29, 2023 13:23
@etorreborre
fix(rust): fix the passing of space name
d872314 
and add a better error for decoding errors for identifiers
@etorreborre etorreborre force-pushed the etorreborre/fix/persistence-issues branch 2 times, most recently from b745505 to 35ac86e Compare November 29, 2023 13:26
@etorreborre etorreborre marked this pull request as ready for review November 29, 2023 13:35
@etorreborre etorreborre requested a review from a team as a code owner November 29, 2023 13:35
@etorreborre etorreborre marked this pull request as draft November 29, 2023 13:43
SanjoDeundiak
SanjoDeundiak previously approved these changes Nov 29, 2023
View reviewed changes
@etorreborre etorreborre force-pushed the etorreborre/fix/persistence-issues branch from 35ac86e to fa41cf3 Compare November 29, 2023 13:45
@etorreborre etorreborre marked this pull request as ready for review November 29, 2023 14:25
SanjoDeundiak
SanjoDeundiak previously approved these changes Nov 29, 2023
View reviewed changes
davide-baldo
davide-baldo previously approved these changes Nov 29, 2023
View reviewed changes
@etorreborre etorreborre added this pull request to the merge queue Nov 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2023
@etorreborre etorreborre requested a review from polvorin November 29, 2023 15:40
@etorreborre etorreborre force-pushed the etorreborre/fix/persistence-issues branch from bd9870f to 3860869 Compare November 29, 2023 16:53
@polvorin polvorin added this pull request to the merge queue Nov 29, 2023
Merged via the queue into develop with commit e4a3709 Nov 29, 2023
27 checks passed
@polvorin polvorin deleted the etorreborre/fix/persistence-issues branch November 29, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polvorin polvorin polvorin approved these changes

@SanjoDeundiak SanjoDeundiak SanjoDeundiak left review comments

@davide-baldo davide-baldo davide-baldo left review comments

Assignees

@etorreborre etorreborre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@etorreborre @davide-baldo @SanjoDeundiak @polvorin