Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): use explicit column lists #7059

Merged
merged 2 commits into from
Dec 11, 2023
Merged

refactor(rust): use explicit column lists #7059

merged 2 commits into from
Dec 11, 2023

Conversation

MatthewLeboffe
Copy link
Contributor

@MatthewLeboffe MatthewLeboffe commented Dec 6, 2023

Current behavior

In this pr, SQL was introduced. Prior to our pull request, SELECT statements in our SQL queries were utilizing the * notation, which fetched all columns indiscriminately. This approach is considered bad practice and an issue was requested to use explicit columns in SELECT statements.

Fixes #6947

Proposed changes

To help prevent mistakes when using SQL queries, we can explicitly specify columns in every SELECT statement, significantly reducing the risk of errors.

Checks

  • All commits in this Pull Request are signed and Verified by Github.
  • All commits in this Pull Request follow the Ockam commit message convention.
  • There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
  • I have read and accept the Ockam Community Code of Conduct.
  • I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@MatthewLeboffe MatthewLeboffe requested review from a team as code owners December 6, 2023 18:32
@mrinalwadhwa
Copy link
Member

@MatthewLeboffe @Sweetsuro thank you for sending the PR.
Thank you for spending time on this, before we can merge could both of you, in 2 separate PRs, please

The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a PR, this will mark the commit as verified.

@Sweetsuro
Copy link
Contributor

Hi @mrinalwadhwa ! I believe we have already done so as a part of this PR, would you rather we have this done in separate in PRs?

@mrinalwadhwa
Copy link
Member

Yes, they have to be 2 separate PRs - one for each of you, for our CI workflows to pick things up correctly. Sorry about the extra steps there.

@Sweetsuro
Copy link
Contributor

Hi @mrinalwadhwa ! Now that both Matthew and I have accepted the clas, and that they are merged, is there anything else we need to do for this PR to be merged?

Copy link
Member

@etorreborre etorreborre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Thanks for your contribution @MatthewLeboffe and @Sweetsuro!

@etorreborre etorreborre added this pull request to the merge queue Dec 11, 2023
Merged via the queue into build-trust:develop with commit 34ac413 Dec 11, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use explicit column list in SELECT SQL statements
4 participants