Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TLS Inlet support #8227

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Added TLS Inlet support #8227

merged 2 commits into from
Sep 13, 2024

Conversation

davide-baldo
Copy link
Member

@davide-baldo davide-baldo commented Jun 27, 2024

Add TLS Inlet support. The TLS certificate is fetched from the project at regular intervals (by default 1 day) and kept in-memory.

Create TCP Inlets

Usage: ockam tcp-inlet create [OPTIONS]

Options:
...
      --tls
          Enable TLS for the TCP Inlet. Uses the default project TLS certificate provider,
          `/project/default/service/tls_certificate_provider`. To specify a different certificate
          provider, use `--tls-certificate-provider`. Requires `ockam-tls-certificate` credential
          attribute

      --tls-certificate-provider <ROUTE>
          Enable TLS for the TCP Inlet using the provided certificate provider. Requires
          `ockam-tls-certificate` credential attribute
Usage: ockam project ticket [OPTIONS]

Options:
...
      --tls
          Allows the access to the TLS certificate of the Project, this flag is transformed into the
          attributes `--attribute ockam-tls-certificate=true`

I've hidden the TLS-related parameter and commented out the bat test, so we can merge it as a disabled feature until we deploy.

@davide-baldo davide-baldo force-pushed the davide-baldo/tls-inlet branch 5 times, most recently from 8cee610 to 919624b Compare July 9, 2024 13:47
@davide-baldo davide-baldo marked this pull request as ready for review July 9, 2024 16:38
@davide-baldo davide-baldo requested a review from a team as a code owner July 9, 2024 16:38
@davide-baldo davide-baldo force-pushed the davide-baldo/tls-inlet branch from 5ec84a9 to 596a590 Compare July 18, 2024 13:24
@davide-baldo davide-baldo force-pushed the davide-baldo/tls-inlet branch 2 times, most recently from 931e9f4 to a3b4641 Compare September 10, 2024 12:59
@davide-baldo davide-baldo added this pull request to the merge queue Sep 13, 2024
Merged via the queue into develop with commit 24dc7dd Sep 13, 2024
29 checks passed
@davide-baldo davide-baldo deleted the davide-baldo/tls-inlet branch September 13, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants