feat(rust): rewrote router into a state container #8641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davide-baldo
force-pushed
the
davide-baldo/router-as-shared-object
branch
6 times, most recently
from
e9dd3e9 to
e047114
Compare
davide-baldo
changed the base branch from
develop
to
davide-baldo/performance
davide-baldo
force-pushed
the
davide-baldo/router-as-shared-object
branch
from
e047114 to
58907c3
Compare
SanjoDeundiak
changed the base branch from
davide-baldo/performance
to
develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fully rewrites the Router in a simple shared state rather than being an actor.
I've also tried to simplify the structure and make it more readable.
Every unused feature was removed (like waiting for a worker/processor to become ready or the immediate shutdown) since it's unused ATM.