Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Vault #8670

Open
wants to merge 2 commits into
base: davide-baldo/kafka-multiple-consumers
Choose a base branch
from

Conversation

davide-baldo
Copy link
Member

@davide-baldo davide-baldo commented Nov 26, 2024

Note

This PR is merging toward davide-baldo/kafka-multiple-consumers rather than develop, but i'll be merged to develop without a second review (unless heavy rebase was needed)

This PR implements the concept of remote vault.
A remote vault is accessing a vault configured in another Ockam Node. This is to allow setting up a shared vault without the need to introduce an external service, which comes really handy for demos and simple setups.
All APIs current supported by Vault are exposed and working, but the secure channel APIs are impractical due to latency and are meant mostly for testing and sketching up a new use case rather than production use.

The remote vault communication happens using a pre-determined identity, authority, and vault. These parameters were serialized inside the database, so we don't need to specify it again every time a remote vault might be used (almost every single command). The remote vault adopts a basic live check, a ping every 10 seconds before usage, if it times out it'll re-connect.

To allow using multiple identities from within the same node, the first commit is about moving the necessary concepts from the node manager to a new ConnectionInstantiator, which holds all the necessary information and traits.

Also, the usage of the log crate was fully removed in favor of trace, to produce a more readable, easier to debug log.

@davide-baldo davide-baldo force-pushed the davide-baldo/ockam-vault-proxy branch 7 times, most recently from 5959158 to 81bf75c Compare December 3, 2024 10:55
@davide-baldo davide-baldo changed the base branch from develop to davide-baldo/kafka-multiple-consumers December 3, 2024 10:55
@davide-baldo davide-baldo force-pushed the davide-baldo/kafka-multiple-consumers branch from e92a7d5 to 412f848 Compare December 3, 2024 13:23
@davide-baldo davide-baldo force-pushed the davide-baldo/ockam-vault-proxy branch from 81bf75c to 5fb3647 Compare December 3, 2024 15:08
@davide-baldo davide-baldo marked this pull request as ready for review December 3, 2024 15:08
@davide-baldo davide-baldo requested a review from a team as a code owner December 3, 2024 15:08
@davide-baldo davide-baldo force-pushed the davide-baldo/ockam-vault-proxy branch 7 times, most recently from f74d7db to 7d2e817 Compare December 4, 2024 16:50
@davide-baldo davide-baldo force-pushed the davide-baldo/kafka-multiple-consumers branch from 412f848 to a98145f Compare December 5, 2024 16:36
@davide-baldo davide-baldo force-pushed the davide-baldo/ockam-vault-proxy branch from 7d2e817 to c76619d Compare December 5, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant