Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): reduce the api versions to the supported range #8682

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

davide-baldo
Copy link
Member

@davide-baldo davide-baldo commented Nov 29, 2024

The latest kafka client 3.9.0 uses the version 4 of ApiVersions request, which is not supported at this time and causes Kafka inlet to fail.
To avoid the above-mentioned failure, and future similar issues, we can reduce the supported API version range only to the supported versions.
The kafka-protocol was updated to the latest version, resulting in some breaking changes.

$ OCKAM=target/debug/ockam DOCS_TESTS=1 ORCHESTRATOR_TESTS=1 bats implementations/rust/ockam/ockam_command/tests/bats/kafka/
docker.bats
 ✓ kafka - docker - end-to-end-encrypted - explicit consumer - redpanda
 ✓ kafka - docker - end-to-end-encrypted - explicit consumer - apache
 ✓ kafka - docker - end-to-end-encrypted - project relay consumer - redpanda
 ✓ kafka - docker - end-to-end-encrypted - project relay consumer - apache
 ✓ kafka - docker - end-to-end-encrypted - rust relay consumer - redpanda
 ✓ kafka - docker - end-to-end-encrypted - rust relay consumer - apache
 ✓ kafka - docker - end-to-end-encrypted - direct connection - redpanda
 ✓ kafka - docker - end-to-end-encrypted - direct connection - apache
 ✓ kafka - docker - end-to-end-encrypted - single gateway - redpanda
 ✓ kafka - docker - end-to-end-encrypted - single gateway - apache
 ✓ kafka - docker - cleartext - redpanda
 ✓ kafka - docker - cleartext - apache
 ✓ kafka - docker - end-to-end-encrypted - offset decryption - redpanda
 ✓ kafka - docker - end-to-end-encrypted - offset decryption - apache
 ✓ kafka - docker - encrypt only two fields - redpanda
 ✓ kafka - docker - encrypt only two fields - apache

@davide-baldo davide-baldo force-pushed the davide-baldo/curb-kafka-api-versions branch from f42b683 to 079c376 Compare November 29, 2024 21:15
@davide-baldo davide-baldo marked this pull request as ready for review November 29, 2024 21:15
@davide-baldo davide-baldo requested a review from a team as a code owner November 29, 2024 21:15
@davide-baldo davide-baldo added this pull request to the merge queue Nov 30, 2024
Merged via the queue into develop with commit f2d0c84 Nov 30, 2024
44 checks passed
@davide-baldo davide-baldo deleted the davide-baldo/curb-kafka-api-versions branch November 30, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants