Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): use legacy netlink ebpf attachment on kernel version 6.6.0+ #8691

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

SanjoDeundiak
Copy link
Member

aya uses newer approach for attaching eBPFs on kernel version 6.6.0+. That attachment approach should be preferable, but currently I notice an unwanted behaviour with it: TC_ACT_PIPE returned from the eBPF doesn't pass the packet to the next eBPF, instead it's treated as TC_ACT_OK and moves the packet further the kernel network stack. This makes impossible attaching more that 1 Ockam eBPF at a time, which means only one Ockam node with Privileged Portals can function at a time on a machine.

This PR is a hotfix and uses older netlink interface to attach the eBPF even if the kernel supports the newer approach.

@SanjoDeundiak SanjoDeundiak requested a review from a team as a code owner December 6, 2024 14:42
@SanjoDeundiak SanjoDeundiak added this pull request to the merge queue Dec 6, 2024
Merged via the queue into develop with commit acd70a2 Dec 6, 2024
29 checks passed
@SanjoDeundiak SanjoDeundiak deleted the sanjo/ebpf_attach_fix branch December 6, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants