Tidy up action cache asset store #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Action Cache Asset Store is a bit hard to work with at the moment. Lots of logic is included in the `Get` and `Put` methods that can be extracted and shared, while also clarifying what's really going on in these methods. I've also modified some of the utility functions to be more generic which has removed a load of boilerplate.
sdclarke
approved these changes
Oct 31, 2024
jjardon
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Action Cache Asset Store is a bit hard to work with at the moment. Lots of logic is included in the
GetandPutmethods that can be extracted and shared, while also clarifying what's really going on in these methods.I've also modified some of the utility functions to be more generic which has removed a load of boilerplate.