Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples #2719

Merged
merged 25 commits into from
Dec 20, 2023
Merged

Add examples #2719

merged 25 commits into from
Dec 20, 2023

Conversation

Dr-Electron
Copy link
Contributor

I started to add examples directly to this repo. I think this makes most sense as they will always be up to date, we can test them and the docs can import them as shown in #2704

Copy link

cloudflare-workers-and-pages bot commented Dec 16, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5a04f4d
Status: ✅  Deploy successful!
Preview URL: https://5236f221.core-3fo.pages.dev
Branch Preview URL: https://add-examples.core-3fo.pages.dev

View logs

@Dr-Electron Dr-Electron changed the base branch from master to develop December 16, 2023 01:05
@adamunchained
Copy link
Collaborator

This is looking great. Could you add an example how this will show in the documentation? Maybe we can start publishing smaller bits so we got something for the release towards the EOW.

@Dr-Electron
Copy link
Contributor Author

This is looking great. Could you add an example how this will show in the documentation? Maybe we can start publishing smaller bits so we got something for the release towards the EOW.

I think for now all examples that work are included and I will start documenting them in #2704 (which already has the first (final) create project example). I will try to finish everything later today

const network = Network.RMS;
let userSign = await walletSign(address.bech32, address);
try {
const projectAPIKey = Build5ApiKey[Build5.TEST];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can actually see where the confusion comes from. Build5ApiKey should be called SoonaverseApiKey instead. We'll tweak. We should add comment above that you're using Soonaverse key to simplify the interaction but users can create their own project.

@Dr-Electron Dr-Electron marked this pull request as ready for review December 19, 2023 22:20
@adamunchained adamunchained merged commit 792358b into develop Dec 20, 2023
1 check passed
@adamunchained adamunchained deleted the add-examples branch December 20, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants