Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk nft purchase #2747

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Bulk nft purchase #2747

merged 1 commit into from
Jan 16, 2024

Conversation

flyingrabbit-lab
Copy link
Collaborator

No description provided.

@flyingrabbit-lab flyingrabbit-lab self-assigned this Jan 11, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 11, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b21af43
Status: ✅  Deploy successful!
Preview URL: https://5514080f.core-3fo.pages.dev
Branch Preview URL: https://impr-2746-bulk-nft.core-3fo.pages.dev

View logs

adamunchained
adamunchained requested changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@adamunchained adamunchained left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, see my comments

...ages/functions/src/services/payment/tangle-service/nft/NftPurchaseBulkTangleRequestSchema.ts Outdated Show resolved Hide resolved
packages/functions/src/controls/nft/NftPurchaseBulkRequestSchema.ts Outdated Show resolved Hide resolved
packages/interfaces/src/models/transaction/common.ts Show resolved Hide resolved
packages/functions/test-tangle/nft-bulk/order.bulk_4.spec.ts Show resolved Hide resolved
packages/interfaces/src/models/transaction/payload.ts Show resolved Hide resolved
packages/interfaces/src/models/transaction/payload.ts Show resolved Hide resolved
packages/interfaces/src/search/post/NftPurchaseBulkRequest.ts Show resolved Hide resolved
@Dr-Electron Dr-Electron mentioned this pull request Jan 13, 2024
Closed
Bulk nft purchase
b21af43 
Fixes

Fixes
@flyingrabbit-lab
Copy link
Collaborator Author

@adamunchained Some test will fail due to Web3. You can ignore those for now.

@adamunchained adamunchained merged commit 2e2575b into develop Jan 16, 2024
82 of 89 checks passed
@adamunchained adamunchained deleted the impr/2746-bulk-nft branch January 16, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamunchained adamunchained adamunchained requested changes

Assignees

@flyingrabbit-lab flyingrabbit-lab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flyingrabbit-lab @adamunchained