-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support experimental Detekt type resolution #118
base: master
Are you sure you want to change the base?
Support experimental Detekt type resolution #118
Conversation
4d8046d
to
0638167
Compare
Tested this against our repository. Will need to do some more testing but this seems to work except for the unused import check, which seems to just be flagging all imports as unused when type resolution is enabled. |
This is great, @Bencodes! We (At Uber) are also looking for similar support. Are there any timelines to merge the changes? |
This should be ready to merge but we found that some of the checks that we rely on right now aren't working with type resolution enabled, which might cause some confusion when opting in to this. @arturdryomov any thoughts on when might be the best time to merge this? We can cut a new release but include a disclaimer about |
@Bencodes, are we talking about built-in checks or internal custom ones? Is there an upstream Detekt issue we can track? |
441fddc
to
e1335cb
Compare
e1335cb
to
a146bf1
Compare
#92