Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support experimental Detekt type resolution #118

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Bencodes
Copy link
Contributor

@Bencodes Bencodes commented Oct 25, 2021

#92

@Bencodes Bencodes force-pushed the support-passing-classpath-information-to-detekt branch from 4d8046d to 0638167 Compare October 25, 2021 19:11
@Bencodes Bencodes changed the title Support passing classpath information to Detekt Support experimental Detekt type resolution Oct 25, 2021
@Bencodes
Copy link
Contributor Author

Tested this against our repository. Will need to do some more testing but this seems to work except for the unused import check, which seems to just be flagging all imports as unused when type resolution is enabled.

@uKetki
Copy link

uKetki commented Nov 11, 2021

This is great, @Bencodes! We (At Uber) are also looking for similar support. Are there any timelines to merge the changes?

@Bencodes
Copy link
Contributor Author

This should be ready to merge but we found that some of the checks that we rely on right now aren't working with type resolution enabled, which might cause some confusion when opting in to this.

@arturdryomov any thoughts on when might be the best time to merge this? We can cut a new release but include a disclaimer about experimental_type_resolution no being stable until the next major Detekt release.

@arturdryomov
Copy link
Contributor

@Bencodes, are we talking about built-in checks or internal custom ones? Is there an upstream Detekt issue we can track?

@Bencodes Bencodes force-pushed the support-passing-classpath-information-to-detekt branch 2 times, most recently from 441fddc to e1335cb Compare March 6, 2022 22:22
@Bencodes Bencodes force-pushed the support-passing-classpath-information-to-detekt branch from e1335cb to a146bf1 Compare March 6, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants