Add config option to disable command modification check #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
option-to-allow-podspecpatch-cmd-mod
branch
6 times, most recently
from
b9e480c to
46c0cc6
Compare
DrJosh9000
force-pushed
the
option-to-allow-podspecpatch-cmd-mod
branch
from
46c0cc6 to
36f42a9
Compare
DrJosh9000
force-pushed
the
option-to-allow-podspecpatch-cmd-mod
branch
from
36f42a9 to
c8baf91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Provide the option to allow PodSpecPatch to modify container commands and args.
Why
It's a recurring request to be able to do this with PodSpecPatch. However the direct modification of the container command (after being carefully set up by the scheduler to run
buildkite-agent) is a "foot-gun".Notes
I've regenerated the TOC in the README because it was slightly out of date.