Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unsupported entry #167

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

dlion
Copy link
Member

@dlion dlion commented Aug 29, 2023

I'm working on a tutorial using the samples and running the detector providing some buildpacks I get an error on the hello-moon one about the version key in the detector file.
The platform_api version I'm using is:

echo $CNB_PLATFORM_API
0.12

this is the output:

❯ $CNB_LIFECYCLE_PATH/detector -log-level debug -layers="./layers" -order="./order.toml" -buildpacks="./buildpacks" -app apps/bash-script
Starting detector...
Parsing inputs...
Ensuring privileges...
Executing command...
Timer: Detector started at 2023-08-29T12:23:26+02:00
======== Results ========
fail: samples/[email protected]
======== Results ========
fail: samples/[email protected]
======== Results ========
fail: samples/[email protected]
======== Error: samples/[email protected] ========
buildpack samples/hello-moon has a "version" key which is not supported. "metadata.version" should be used instead
======== Results ========
pass: samples/[email protected]
err:  samples/[email protected]
Timer: Detector ran for 152.19425ms and ended at 2023-08-29T12:23:26+02:00
ERROR: No buildpack groups passed detection.
ERROR: failed to detect: buildpack(s) failed with err

No new files have been generated.

Removing that line from the detector I get:

❯ $CNB_LIFECYCLE_PATH/detector -log-level debug -layers="./layers" -order="./order.toml" -buildpacks="./buildpacks" -app apps/bash-script
Starting detector...
Parsing inputs...
Ensuring privileges...
Executing command...
Timer: Detector started at 2023-08-29T12:27:19+02:00
======== Results ========
fail: samples/[email protected]
======== Results ========
fail: samples/[email protected]
======== Results ========
fail: samples/[email protected]
======== Results ========
pass: samples/[email protected]
pass: samples/[email protected]
Resolving plan... (try #1)
samples/hello-world 0.0.1
samples/hello-moon  0.0.1
Timer: Detector ran for 974.819292ms and ended at 2023-08-29T12:27:20+02:00

and the plan.toml and group.toml files are there as expected.

Signed-off-by: Domenico Luciani <[email protected]>
@dlion dlion requested a review from a team as a code owner August 29, 2023 10:32
Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natalieparellano natalieparellano merged commit 29b228b into buildpacks:main Sep 7, 2023
5 checks passed
@dlion dlion deleted the patch-1 branch September 15, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants