GifDrawable: Call stop before notifying end to listeners #5451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current code, `GifDrawable` calls the `onAnimationEnd` callback first and then invokes `stop()` to end the animation. This behavior prevents the following use-case: An app wants to schedule another loop of the `GifDrawable` when the current loop ends (i.e.) calls `start()` from within the `onAnimationEnd()` callback. This doesn't work because `stop()` is called right after the onAnimationEnd() callback is complete. Reversing the order of these two calls to enable this use-case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current code,
GifDrawablecalls theonAnimationEndcallback first and then invokesstop()to end the animation.This behavior prevents the following use-case: An app wants to schedule another loop of the
GifDrawablewhen the current loop ends (i.e.) callsstart()from within theonAnimationEnd()callback. This doesn't work becausestop()is called right after the onAnimationEnd() callback is complete.Reversing the order of these two calls to enable this use-case.