Authz Code ID Proxy Contract Example #35
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adairrr
reviewed
Nov 15, 2024
Comment on lines
+89
to
+123
| pub fn is_admin(deps: Deps, address: Addr) -> ContractResult<()> { | ||
| let admin = ADMIN.load(deps.storage)?; | ||
| match admin { | ||
| None => Err(Unauthorized), | ||
| Some(a) => { | ||
| if a != address { | ||
| Err(Unauthorized) | ||
| } else { | ||
| Ok(()) | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| pub fn update_admin( | ||
| deps: DepsMut, | ||
| info: MessageInfo, | ||
| new_admin: Option<Addr>, | ||
| ) -> ContractResult<Response> { | ||
| is_admin(deps.as_ref(), info.sender.clone())?; | ||
|
|
||
| ADMIN.save(deps.storage, &new_admin)?; | ||
|
|
||
| let admin_str: String = match new_admin { | ||
| None => String::new(), | ||
| Some(a) => a.into_string(), | ||
| }; | ||
|
|
||
| Ok( | ||
| Response::new().add_event(Event::new("updated_treasury_admin").add_attributes(vec![ | ||
| ("old admin", info.sender.into_string()), | ||
| ("new admin", admin_str), | ||
| ])), | ||
| ) | ||
| } |
There was a problem hiding this comment.
cw-ownable removes all this boilerplate: https://crates.io/crates/cw-ownable
| use cw_storage_plus::{Item, Map}; | ||
|
|
||
| pub const ADMIN: Item<Option<Addr>> = Item::new("admin"); | ||
| pub const CODE_IDS: Map<u64, bool> = Map::new("code_ids"); |
There was a problem hiding this comment.
| @@ -0,0 +1,77 @@ | |||
| use crate::msg::{get_inner, ExecuteMsg, InnerExecuteMsg, InstantiateMsg, MigrateMsg, QueryMsg}; | |||
There was a problem hiding this comment.
This cw721-proxy acts as an cw721 adapter module within Abstract SDK: https://docs.abstract.money/3_framework/6_module_types.html#adapters
Happy to go over the different modules and how to build them, as it removes a ton of boilerplate, makes the contract more upgradeable, and the module code has already been audited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.