Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/authz grants #5

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Feat/authz grants #5

wants to merge 9 commits into from

Conversation

Peartes
Copy link
Contributor

@Peartes Peartes commented May 10, 2024

No description provided.

@Peartes Peartes self-assigned this May 10, 2024
@Peartes Peartes requested a review from justinbarry May 10, 2024 20:07
package.json Outdated
@@ -4,7 +4,8 @@
"description": "This is the indexer solution for the xion chain",
"main": "dist/index.js",
"scripts": {
"build": "subql build",
"build": "rm -rf dist && subql build",
"generate:proto:types": "protoc --plugin=./node_modules/.bin/protoc-gen-ts_proto --ts_proto_out=src/types/ --ts_proto_opt=useDate=false --proto_path proto $1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does $1 mean here?

Copy link
Contributor Author

@Peartes Peartes May 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the first argument passed to the command. It should be the proto file to compile

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add that to the readme?

justinbarry
justinbarry previously approved these changes May 10, 2024
Copy link
Contributor

@justinbarry justinbarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants