Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/fetch-all-supported-configurations #7

Merged
merged 5 commits into from
Oct 22, 2023

Conversation

busticated
Copy link
Owner

@busticated busticated commented Oct 22, 2023

Description

Adds .fetch_all() method to the node-js-release-info crate to retrieve list of supported configurations.

How to Test

  1. Clone and setup this branch locally (docs)
  2. Review docs for .fetch_all(): cargo xtask doc --open
  3. Run tests: cargo xtask test
  4. Try out the examples

Outcome

Tests should pass, docs and examples should be clear and helpful, and you should be able to successfully replicate and run the examples.

Related / Discussions

N/A

Completeness

  • PR opened 🎉
  • Testing instructions have been provided
  • Development How-To's have been provided
  • Docs have been updated (cargo xtask doc)
  • Branch is rebased against target (typically main)

@busticated busticated force-pushed the feature/fetch-all-supported-configurations branch from b892156 to 9fc47f0 Compare October 22, 2023 02:43
@busticated
Copy link
Owner Author

🎈🥳 :shipit:

@busticated busticated merged commit 8d77010 into main Oct 22, 2023
6 checks passed
@busticated busticated deleted the feature/fetch-all-supported-configurations branch October 22, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant