Fix onDragging regression (#391)

Resolves #388
bvaughn · Aug 21, 2024 · adc9038 · adc9038
1 parent 072c116
commit adc9038
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 5 deletions.
diff --git a/packages/react-resizable-panels-website/src/components/ResizeHandle.tsx b/packages/react-resizable-panels-website/src/components/ResizeHandle.tsx
@@ -4,11 +4,9 @@ import styles from "./ResizeHandle.module.css";
 
 export function ResizeHandle({
   className = "",
-  collapsed = false,
   id,
 }: {
   className?: string;
-  collapsed?: boolean;
   id?: string;
 }) {
   return (

diff --git a/packages/react-resizable-panels/src/PanelResizeHandle.test.tsx b/packages/react-resizable-panels/src/PanelResizeHandle.test.tsx
@@ -336,13 +336,32 @@ describe("PanelResizeHandle", () => {
     expect(onDraggingLeft).toHaveBeenCalledWith(true);
 
     expect(cursorUtils.resetGlobalCursorStyle).not.toHaveBeenCalled();
-    expect(cursorUtils.setGlobalCursorStyle).toHaveBeenCalledTimes(1);
+    expect(cursorUtils.setGlobalCursorStyle).toHaveBeenCalled();
+
+    onDraggingLeft.mockReset();
+
+    act(() => {
+      dispatchPointerEvent("pointermove", leftElement);
+    });
+    expect(onDraggingLeft).not.toHaveBeenCalled();
+
+    act(() => {
+      dispatchPointerEvent("pointerup", leftElement);
+    });
+    expect(onDraggingLeft).toHaveBeenCalledTimes(1);
+    expect(onDraggingLeft).toHaveBeenCalledWith(false);
+
+    onDraggingLeft.mockReset();
+
+    act(() => {
+      dispatchPointerEvent("pointermove", leftElement);
+    });
+    expect(onDraggingLeft).not.toHaveBeenCalled();
 
     act(() => {
       root.unmount();
     });
 
     expect(cursorUtils.resetGlobalCursorStyle).toHaveBeenCalled();
-    expect(cursorUtils.setGlobalCursorStyle).toHaveBeenCalledTimes(1);
   });
 });
diff --git a/packages/react-resizable-panels/src/PanelResizeHandleRegistry.ts b/packages/react-resizable-panels/src/PanelResizeHandleRegistry.ts
@@ -109,7 +109,7 @@ function handlePointerMove(event: PointerEvent) {
 
   // Edge case (see #340)
   // Detect when the pointer has been released outside an iframe on a different domain
-  if (event.buttons === 0) {
+  if (isPointerDown && event.buttons === 0) {
     isPointerDown = false;
 
     updateResizeHandlerStates("up", event);