feat: add refs to underlying DOM elements in imperative API #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `elementRef: RefObject<HTMLElement>` to both `ImperativePanelHandle` and `ImperativePanelGroupHandle`, giving access to the underlying DOM elements for these components.
Updates Imperative API docs.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I don't think I want to approach exposing the DOM elements this way. Having multiple "ref" properties for a component– one that points to the DOM element and one that points to an imperative API– feels odd to me. I have some utilities that I use internally for querying the underling DOM elements. I think maybe I can export those publicly though, to fit your original use case. They are here: https://github.com/bvaughn/react-resizable-panels/tree/main/packages/react-resizable-panels/src/utils/dom Give me some time to think over this. :) |
|
Sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #248
No worries if this feature isn't accepted, or the implementation should be different.