fix: cannot passed element id in <Panel /> <PanelGroup />, <PanelResizeHandle />
#299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bvaughn
approved these changes
Feb 13, 2024
|
I think this could be considered a breaking change 🤔 I think it may be safer to only pass through ids from props (ones explicitly assigned by users, not the auto-generated ones I use internally) |
|
Thanks for the PR! This change just went out in 2.0.8 ❤️ → ☕ givebrian.coffee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found while writing a11y tests using axe-core that the
<Panel />,<PanelGroup />, and<PanelResizeHandle />ids are not being passed properly.