Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid recording on forks #350

Closed
wants to merge 3 commits into from

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented May 2, 2024

No description provided.

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-resizable-panels ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 2:20pm

apiKey: process.env.REPLAY_API_KEY,
upload: true,
}),
process.env.REPLAY_API_KEY
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatively, you could fork the behavior based on if: github.repository == 'bvaughn/react-resizable-panels' in the workflow file

@bvaughn
Copy link
Owner

bvaughn commented May 2, 2024

e2e test is failing now

  1. [replay-chromium] › tests/Storage.spec.ts:30:10 › Storage › localStorage (default) › should restore previous layout if autoSaveId prop has been provided
    'Socket errored'
    1 failed
    [replay-chromium] › tests/Storage.spec.ts:30:10 › Storage › localStorage (default) › should restore previous layout if autoSaveId prop has been provided

I can't stop and dig into it right now unfortunately. I'm just spread too thin. Going to leave this PR unmerged.

@Andarist
Copy link
Contributor Author

Andarist commented May 2, 2024

Ah ye, this makes sense - it's something I noticed an hour ago. Don't bother with this as it's something to be fixed purely on the Playwright plugin's side of things

@bvaughn bvaughn closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants