Further obfuscate reference to React.useId #382
Conversation
Use technique from this comment: mui/material-ui#41190 (comment) to further obfuscate reference to `React.useId` which causes issue when using `react-resizable-panels` with React <18 and `esbuild` > 0.19.5. Fixes bvaughn#381
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@bvaughn Any thoughts on the proposed changes? |
|
Hey @nwidger. Busy week for me (lots of interviews) so I hadn't looked at this yet. Looks okay I guess. JS bundlers are weird. I wish there was a standard directive or something that we could use to opt out of this kind of "smart" optimization but 🤷🏼 There's a formatting issue that's causing CI to be unhappy. I left a comment. |
Use formatting required by Prettier for this file. Co-authored-by: Brian Vaughn <[email protected]>
|
@bvaughn No worries at all! And thanks for the fix to (hopefully) make CI happy. I totally agree, JS bundlers are weird. I was pretty surprised to learn that packages like this one that want to handle multiple versions of React but fallback gracefully if certain features aren't available are forced to do these sorts of things. But as you said, 🤷 |
|
Sorry it's taking me a while to get back to this. Been a really busy few days on my side. |
Use technique from this comment: mui/material-ui#41190 (comment) to further obfuscate reference to
React.useIdwhich causes issue when usingreact-resizable-panelswith React <18 andesbuild> 0.19.5.Fixes #381