Better times #492
Merged
Better times #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rugk, @gaul, @lmorchard : I know it's been a while, but did any of you want to take a look at this before I merge it? 🙂 |
|
Thanks a lot for all the work you've put into this here! Edit: Oh sorry was too late for me to get things right. You are the maintainer, so thanks a lot in any case! I don't have any particular knowledge here regarding sass or so, but yay… 🙂 |
rugk
approved these changes
Aug 28, 2021
There was a problem hiding this comment.
LGTM. Only one general note for further maintainance: MomentJS is more or less deprecated, as it stands now: https://momentjs.com/docs/#/-project-status/
gaul
approved these changes
Aug 28, 2021
… before the current day.
|
Good catch on the Moment deprecation. Day.js looks like the easiest replacement, so if we make more changes we should probably switch to that… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #418, #475, #476, #486 (kind of).