This repository has been archived by the owner on May 3, 2024. It is now read-only.
Replace hardcoded container port with value. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The container does not start on openshift (OKD 4.9) because pod security policy / security context constraint disallows container to open port numbers < 1024 .
Other security oriented kubernetes "distros" may be similar. The change does not affect the function of the deployment but just maps target port of the service to the value of container-port and open that port in the container spec. Also the webhook service is configured to listen to that same port by adding argument --secure-port and set it to the value of containerport which now defaults to 8443.