Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reintroduce single device simulator as an uplink built-in #274

Merged
merged 4 commits into from
Sep 4, 2023

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Aug 23, 2023

Closes #

Currently built-in simulator works with the principle of multi-device simulation, which doesn't work for certain parts like the TLS reliant downloader, thus it was necessary to create a simulator.sh that runs a utility along with uplink to simulate data. Since then we have progressed a lot and the complexity of multi-device simulation support has become a thorn in the code's readability and with this change removing the same is the goal.

Changes

  • Copy code from tools/simulator into collector/simulator and refactor it to work within uplink as a built-in
  • Remove all code in uplink that is there only to supports multi-device simulation
  • Update simulator.sh to use built-in-sim

Why?

This will decrease the complexity of simulator.sh by quite a bit and since we have fewer processes running, could also impact performance.

Trials Performed

Run simulator.sh with appropriate env vars, contents of devices/uplink_<device_id>.log

@de-sh de-sh marked this pull request as ready for review August 23, 2023 05:19
@de-sh de-sh requested a review from tekjar September 1, 2023 10:00
@de-sh de-sh merged commit 9109c75 into main Sep 4, 2023
2 checks passed
@de-sh de-sh deleted the built-in-sim branch September 4, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant