refactor: reintroduce single device simulator as an uplink built-in #274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Currently built-in simulator works with the principle of multi-device simulation, which doesn't work for certain parts like the TLS reliant downloader, thus it was necessary to create a simulator.sh that runs a utility along with uplink to simulate data. Since then we have progressed a lot and the complexity of multi-device simulation support has become a thorn in the code's readability and with this change removing the same is the goal.
Changes
tools/simulator
intocollector/simulator
and refactor it to work within uplink as a built-insimulator.sh
to use built-in-simWhy?
This will decrease the complexity of simulator.sh by quite a bit and since we have fewer processes running, could also impact performance.
Trials Performed
Run
simulator.sh
with appropriate env vars, contents ofdevices/uplink_<device_id>.log