Backport patches to the 0.38 branch #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `waitpid` tests, explicitly terminate the child processe and wait for them to exit, as dropping a `Command` otherwise leaves the process running. This fixes test hangs on macos.
According to [this page], the official site for the glibc documentation is [here] now. Update URLs accordingly. And add links for glibc's documentation for `pread`, `pwrite`, `readv`, `writev`, `preadv2` and `pwritev2`. [this page]: https://www.gnu.org/software/libc/manual/ [here]: https://sourceware.org/glibc/manual/
static mut is now discouraged; however it appears that the places we use static mut can be removed pretty easily. Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Fixing low-hanging-fruit issue #1051. Signed-off-by: John Nunley <[email protected]>
* Implement `select`. Add a `select` function, defined only on platforms where it doesn't have an `FD_SETSIZE` limitation. * Fix test hangs on macos. In the `waitpid` tests, ensure that the child process has exited, as dropping `Command` otherwise leaves the process running. This fixes test hangs on macos. * Wait for the child process after signaling it. * Fix the vector sizes in the test. * Add `fd_set` and other convenience functions. * Switch to a safe API. * Support `select` on Linux and Windows too. This uses a trick where we still allow users to allocate a `FdSetElement` array, but we just allocate a `FD_SET` on Windows out of it. And make `select` unsafe due to I/O safety. * Fix qemu to implment arbitrary-sized fd sets for `select`. * Support WASI. * Ignore "unstable name collisions" warnings for now.
These functions were added to libc 0.2.161, and are required by some downstream crates.
sunfishcode
force-pushed
the
0.38-updates
branch
from
4a8f278 to
4739956
Compare
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport several patches to the 0.38 branch.