fix: enable wasip2 feature for wasm32-wasip2 target #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Colin Murphy <[email protected]>
sunfishcode
reviewed
Nov 4, 2024
Cargo.toml
Outdated
| @@ -13,7 +13,7 @@ edition = "2021" | |||
| keywords = ["api", "file", "network", "safe", "syscall"] | |||
| categories = ["os::unix-apis", "date-and-time", "filesystem", "network-programming"] | |||
| include = ["src", "build.rs", "Cargo.toml", "COPYRIGHT", "LICENSE*", "/*.md", "benches"] | |||
| rust-version = "1.63" | |||
There was a problem hiding this comment.
Could you revert this rust-version change? It isn't practical for us to bump the MSRV for all rustix users. Since wasip2 is a new target, I think we can just leave rust-version at 1.63 and just expect people using wasip2 to use the lastest Rust version.
|
Thanks! |
sunfishcode
pushed a commit
that referenced
this pull request
Nov 4, 2024
* fix: enable wasip2 feature for wasm32-wasip2 target Signed-off-by: Colin Murphy <[email protected]> * Do not change MSRV --------- Signed-off-by: Colin Murphy <[email protected]>
sunfishcode
pushed a commit
that referenced
this pull request
Nov 4, 2024
* fix: enable wasip2 feature for wasm32-wasip2 target Signed-off-by: Colin Murphy <[email protected]> * Do not change MSRV --------- Signed-off-by: Colin Murphy <[email protected]>
|
This is now released in rustix 0.38.39. |
Stebalien
added a commit
to Stebalien/tempfile
that referenced
this pull request
Nov 8, 2024
- wasip2 will require +nightly until rust-lang/rust#130323 is resolved and/or std::os::wasip2 is available in stable. - Support was added to rustix for version 0.38.39 bytecodealliance/rustix#1205 Signed-off-by: Colin Murphy <[email protected]> Co-authored-by: Steven Allen <[email protected]>
cdmurph32
added a commit
to cdmurph32/c2pa-rs
that referenced
this pull request
Nov 12, 2024
- wasip2 will require +nightly until rust-lang/rust#130323 is resolved and/or std::os::wasip2 is available in stable. - Support was added to rustix for version 0.38.39 bytecodealliance/rustix#1205 - Support was added to tempfile for version 3.14 Stebalien/tempfile#305
cdmurph32
added a commit
to cdmurph32/c2pa-rs
that referenced
this pull request
Nov 12, 2024
- wasip2 will require +nightly until rust-lang/rust#130323 is resolved and/or std::os::wasip2 is available in stable. - Support was added to rustix for version 0.38.39 bytecodealliance/rustix#1205 - Support was added to tempfile for version 3.14 Stebalien/tempfile#305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::os::wasip2is available in stable. (please correct me if I'm wrong about that)