Fix tests on illumos. #1238
Merged
Fix tests on illumos. #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the layout of `epoll::Event` on x86 and x86_64 on illumos to match libc's layout. Adjust tests in tests/net/sockopt.rs to avoid using a buffer larger than supported on illumos. And change tests/pty/openpty.rs to avoid expecting we can write an EOF to a pty on illumos, as that doesn't appear to work.
sunfishcode
force-pushed
the
sunfishcode/illumos-fixes
branch
from
5fdb686 to
01ce127
Compare
sunfishcode
added a commit
that referenced
this pull request
Dec 9, 2024
Fix the layout of `epoll::Event` on x86 and x86_64 on illumos to match libc's layout. Adjust tests in tests/net/sockopt.rs to avoid using a buffer larger than supported on illumos. And change tests/pty/openpty.rs to avoid expecting we can write an EOF to a pty on illumos, as that doesn't appear to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the layout of
epoll::Eventon x86 and x86_64 on illumos to match libc's layout.Adjust tests in tests/net/sockopt.rs to avoid using a buffer larger than supported on illumos.
And change tests/pty/openpty.rs to avoid expecting we can write an EOF to a pty on illumos, as that doesn't appear to work.