Handle static PIE in startup_tls_info.
#850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In static PIE mode, we don't get a `PT_PHDR` segment, but we do get a `PT_DYNAMIC` segment, and we can compare that against the `_DYNAMIC` symbol that the linker creates and dynamic linker relocates to learn our virtual address offset.
This makes the code independent of whether the offset is positive or negative.
sunfishcode
added a commit
to sunfishcode/origin
that referenced
this pull request
Sep 25, 2023
rustix exports all the functions needed to do what `startup_tls_info` does, so the code can live in origin, and it makes more sense to have it in origin. Also incorporate bytecodealliance/rustix#850, handling static PIE by adding logic to compute the load offset using the difference between the `PT_DYNAMIC` static address and the dynamic address of the `_DYNAMIC` symbol.
|
I think a better approach here is to move |
sunfishcode
added a commit
to sunfishcode/origin
that referenced
this pull request
Sep 25, 2023
rustix exports all the functions needed to do what `startup_tls_info` does, so the code can live in origin, and it makes more sense to have it in origin. Also incorporate bytecodealliance/rustix#850, handling static PIE by adding logic to compute the load offset using the difference between the `PT_DYNAMIC` static address and the dynamic address of the `_DYNAMIC` symbol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In static PIE mode, we don't get a
PT_PHDRsegment, but we do get aPT_DYNAMICsegment, and we can compare that against the_DYNAMICsymbol that the linker creates and dynamic linker relocates to learn our virtual address offset.