Add connect_unspec #895
Closed
Add connect_unspec #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badeend
force-pushed
the
connect_unspec
branch
3 times, most recently
from
b313ab2 to
2f170c4
Compare
badeend
force-pushed
the
connect_unspec
branch
from
2f170c4 to
0227cfd
Compare
sunfishcode
reviewed
Oct 25, 2023
|
|
||
| /// Even though an AF_UNSPEC socket address contains only the family, they're | ||
| /// still required to be at least as big as the socket's regular address structure. | ||
| /// We (ab)use `sockaddr_in6` to push the size up to satisfy both IPv4 and IPv6 sockets. |
There was a problem hiding this comment.
Could you say more about what requires the encoded socket to be as big as the socket's regular address structure? If the socket is not IPv4 or IPv6, what would happen here? Would it make sense to use c::sockaddr_storage here instead?
|
Replaced by #902 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main use case: to change a UDP socket's association.