Bump version numbers and try to future-proof #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yesterday's publish is not the first time where something needed a major bump was forgotten, so this is an attempt to mitigate future issues. This requires handwriting the list of public dependencies but that's hopefully not too bad.
pchickey
approved these changes
Oct 13, 2023
fitzgen
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to address a mistake in #1247 where that PR bumped a major version of
wit-parserbut mistakenly forgot to bump the major version ofwit-component. (I forgot to see that!) This caused downstream issues and broke builds such as in bytecodealliance/wit-bindgen#698.I've updated the
publish.rsscript to have knowledge of public dependencies and automaticlaly force a major version bump of wit-component, for example, if wit-parser has a major version bump.This PR additionally bumps version numbers and I'll yank the buggy versions after these are published.