Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build of wast with randomized layouts #1751

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Fix build of wast with randomized layouts #1751

merged 1 commit into from
Sep 3, 2024

Conversation

alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Aug 31, 2024 •
edited
Loading

Closes #1750

the8472
the8472 reviewed Aug 31, 2024
View reviewed changes
crates/wast/src/lexer.rs Outdated Show resolved Hide resolved
the8472
the8472 approved these changes Sep 3, 2024
View reviewed changes
Copy link

@the8472 the8472 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI test is good, then it won't break downstream users.

@alexcrichton
Fix build of wast with randomized layouts
e10395a 
Move the static assertion about size to a runtime test to enable
building with randomized layouts for testing.
@alexcrichton alexcrichton added this pull request to the merge queue Sep 3, 2024
Merged via the queue into bytecodealliance:main with commit 8c3346e Sep 3, 2024
29 checks passed
@alexcrichton alexcrichton deleted the fix-build branch September 3, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the8472 the8472 the8472 approved these changes

@abrown abrown abrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wast lexer size assert not compatible with randomized struct layouts
3 participants
@alexcrichton @abrown @the8472