Prevent JVM System.loadLibrary call that looks through all paths

[abbasvalliani]

Currently, even if java.library.path is set to nothing, the System.loadLibrary is called which searches through all paths to load the libraries. This creates a significant delay in startup.

[saudet]

It doesn't do that to start with, this is not an issue: #456 (comment)

[saudet]

Please let me know how to reproduce the initial issue. It's not worth merging this if everything works as expected already.

[abbasvalliani]

Clearly their is an issue in windows. Mac and Linux is perfectly fine. Will create a simple example tomorrow and figure it out.  On 2/11/2021 7:18:50 PM, Samuel Audet <[email protected]> wrote: Please let me know how to reproduce the initial issue. It's not worth merging this if everything works as expected already. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub [#457 (comment)], or unsubscribe [https://github.com/notifications/unsubscribe-auth/AFO5B33JF4OICB5MPVOSWNDS6RXWTANCNFSM4XD64DVQ].

[saudet]

I can't reproduce this on my installation of Windows 10 either. This is what I get with libopenblas.dll from MSYS2 in the PATH:

public class TestLoad {
    public static void main(String[] args) {
        System.loadLibrary("libopenblas");
    }
}

$ java -version
java version "1.8.0_152"
Java(TM) SE Runtime Environment (build 1.8.0_152-b16)
Java HotSpot(TM) 64-Bit Server VM (build 25.152-b16, mixed mode)

$ java TestLoad

$ java -Djava.library.path= TestLoad
Exception in thread "main" java.lang.UnsatisfiedLinkError: no libopenblas in java.library.path
        at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1867)
        at java.lang.Runtime.loadLibrary0(Runtime.java:870)
        at java.lang.System.loadLibrary(System.java:1122)
        at TestLoad.main(TestLoad.java:3)

[saudet]

BTW, if you've only tried it with mvn -Djava.library.path= ..., it might be because Maven sets the system property too late.
Try instead setting the environment variable MAVEN_OPTS=-Djava.library.path=.