Refactor solcates' changes

kube/completer.go

@@ -291,12 +291,10 @@ func argumentsCompleter(args []string) []prompt.Suggest {
 		if len(args) == 2 {
 			return prompt.FilterHasPrefix(resourceTypes, args[1], true)
 		}
-		second := args[1]
 
-		// TODO: Add suggestions for Deployments
-		third := args[2]
 		if len(args) == 3 {
-			switch second {
+			third := args[2]
+			switch args[1] {
 			case "componentstatuses", "cs":
 				return prompt.FilterContains(getComponentStatusCompletions(), third, true)
 			case "configmaps", "cm":
@@ -411,14 +409,12 @@ func argumentsCompleter(args []string) []prompt.Suggest {
 			{Text: "use-context", Description: "Sets the current-context in a kubeconfig file"},
 			{Text: "view", Description: "Display merged kubeconfig settings or a specified kubeconfig file"},
 		}
-		second := args[1]
-
 		if len(args) == 2 {
 			return prompt.FilterHasPrefix(subCommands, args[1], true)
 		}
-		third := args[2]
 		if len(args) == 3 {
-			switch second {
+			third := args[2]
+			switch args[1] {
 			case "use-context":
 				return prompt.FilterContains(getContextSuggestions(), third, true)
 			}

kube/executor.go

@@ -1,11 +1,12 @@
 package kube
 
 import (
+	"bytes"
+	"errors"
 	"fmt"
 	"os"
 	"os/exec"
 	"strings"
-	"bytes"
 )
 
 func Executor(s string) {
@@ -28,21 +29,19 @@ func Executor(s string) {
 	return
 }
 
-func ExecuteAndReturnList(s string) (list []string) {
+func ExecuteAndGetResult(s string) (string, error) {
 	s = strings.TrimSpace(s)
 	if s == "" {
-		return
+		return "", errors.New("you need to pass the something arguments")
 	}
 
 	out := &bytes.Buffer{}
 	cmd := exec.Command("/bin/sh", "-c", "kubectl "+s)
 	cmd.Stdin = os.Stdin
 	cmd.Stdout = out
 	if err := cmd.Run(); err != nil {
-		fmt.Printf("Got error: %s\n", err.Error())
+		return "", err
 	}
-
-	ss := string(out.Bytes())
-	return strings.Split(ss, "\n")
-
+	r := string(out.Bytes())
+	return r, nil
 }

kube/resource.go

@@ -2,7 +2,9 @@ package kube
 
 import (
 	"fmt"
+	"log"
 	"sort"
+	"strings"
 	"sync/atomic"
 	"time"
 
@@ -139,10 +141,11 @@ func fetchContextList() {
 	if time.Since(contextLastFetchAt) < thresholdFetchInterval {
 		return
 	}
-	// TODO: Get a list of config get-context
-	list := ExecuteAndReturnList("config get-contexts --no-headers -o name")
-
-	contextList.Store(list)
+	r, err := ExecuteAndGetResult("config get-contexts --no-headers -o name")
+	if err != nil {
+		log.Printf("[WARN] Got Error when fetchContextList: %s", err.Error())
+	}
+	contextList.Store(strings.Split(r, "\n"))
 }
 
 func getContextSuggestions() []prompt.Suggest {
@@ -154,8 +157,7 @@ func getContextSuggestions() []prompt.Suggest {
 	s := make([]prompt.Suggest, len(l))
 	for i := range l {
 		s[i] = prompt.Suggest{
-			Text:        l[i],
-			Description: string(l[i]),
+			Text: l[i],
 		}
 	}
 	return s