Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split not working for images #27

Open
realitylab-ruben opened this issue Apr 1, 2018 · 0 comments · May be fixed by #45
Open

Split not working for images #27

realitylab-ruben opened this issue Apr 1, 2018 · 0 comments · May be fixed by #45

Comments

@realitylab-ruben
Copy link

For a project I'm currently working on, I'm receiving the panoramic render in dual mode as well(top for the left eye, bottom for the right eye). However, when I tried to implement this into the project, I was unable to get it running properly. After doing a bit of investigating, I found out this was happening because of the following...

index.js:49 if (isValidGeometry && this.material_is_a_video) {

If I removed && this.material_is_a_video, everything seemed to be working fine, but of course, now existing images will be broken, so this would likely require a bit of refactoring to get this working correctly.

Now, before doing a PR for this, I was wondering if there is a specific reason why images can't be split up at all?

@vincentfretin vincentfretin linked a pull request Jun 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant