-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to allow stereo images #45
base: master
Are you sure you want to change the base?
Conversation
Also the changes break the boxes example, transforming the box to a sphere because a box is a valid BufferGeometry. I'm not sure how we can keep backward compatibility for this case. In the case of the boxes example, the stereo component is just used to set the layer. For this use case, we also have the more generic layers component supporting any layer value, not just 1 (eye:left) and 2 (eye:right). |
I actually replaced
in my fork, only handling sphere geometry, and using the layers component combined with the mirror component for example where you can specify the layers you want to render in the mirror. |
In this project the aframe-stereo-component was used as basis to show stereo images in JPS format. He did it on top of it instead of doing breaking changes, so it could be of your interest: |
Thanks @nuess0r you can indeed have two images, one for left and one for right and just use I'm using my own changes of stereo component for years now with top/bottom images. A few years back I had top/bottom 360 videos and extracted a single frame from it, so I had a single file and I just did this change to make it work with |
This is a non compatible change, so probably will never be merged in this state, but for those wanting to use a stereo image the same as a stereo video, here are the changes needed.
This fixes #27